[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] PPC: Fix linker scripts on ppc hosts

From: Alexander Graf
Subject: Re: [Qemu-devel] [PATCH] PPC: Fix linker scripts on ppc hosts
Date: Tue, 13 Dec 2011 22:59:41 +0100

On 13.12.2011, at 17:31, Paul Brook <address@hidden> wrote:

>> On 13.12.2011, at 07:19, Paul Brook <address@hidden> wrote:
>>>>> When compiling qemu statically with multilib on PPC, we hit the
>>>>> same issue that commit 845f2c2812d9ed24b36c02a3d06ee83aeafe8b49
>>>>> is fixing. Do the same here.
>>>> How many of these ld files can we get rid of if we use -Ttext-segment
>>>> instead? Generally all we're really caring about is moving the program
>>>> base around so that it doesn't conflict with the address space we want
>>>> to use for the client.
>>> Now that we have the automatic GUEST_BASE stuff you shouldn't need to do
>>> either.
>> If it was working, yes :)
> What doesn't work?  I put a fair amout of effort into making it automatically 
> pick a sensible value.  If there's some reason that won't work then you 
> probably want to be using -R.

IIRC mmap'ing files would break with 32-on-64, but I'd have to check up on the 
details. I ended up passing MAP_32BIT to all linux-user mmap calla for 
32-on-x86_64, but that doesn't work with -R.

But either way, this patch fixes an immediate build failure on ppc hosts for us 
and should regardless be applied to 1.0-stable. I would also vote for adding it 
to HEAD now and go for the removal of all linker scripts later, if we're sure 
we don't have any regressions.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]