[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Dropping the MONITOR_CMD_ASYNC

From: Avi Kivity
Subject: Re: [Qemu-devel] Dropping the MONITOR_CMD_ASYNC
Date: Tue, 13 Dec 2011 13:06:32 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0

On 12/12/2011 06:26 PM, Anthony Liguori wrote:
> Nope, it has to be dropped.
> Commands using CMD_ASYNC may fail in arbitrary ways because of the way
> error reporting is done.  This is an unfixable problem until we
> eliminate all uses of qerror_report().

Why don't we eliminate all uses for qerror_report() then?  Breaking our
interfaces instead seems like a horrible idea.

> We need to take the hit here and force the command to always fail. 
> libvirt will need logic to use a different command with new versions. 
> If we coordinate this with the libvirt folks, we can make the
> transition as smooth as possible.

I thought we've outgrown this.  If we provide an interface, we should
support it.

error compiling committee.c: too many arguments to function

reply via email to

[Prev in Thread] Current Thread [Next in Thread]