[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/6] memory: change dirty setting APIs to take a
Re: [Qemu-devel] [PATCH 2/6] memory: change dirty setting APIs to take a size
Mon, 12 Dec 2011 11:45:57 +0100
Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux)
Blue Swirl <address@hidden> wrote:
> Instead of each target knowing or guessing the guest page size,
> just pass the desired size of dirtied memory area. This should also
> improve performance due to memset() optimizations.
My understanding last time I looked at this, is that it is as easy
basically to change the interface to work on pages, not on addresses.
I looked at the interface from the point of view of migration, and I
always needed a "page". My understanding at the time was that every
caller could be change to use a page instead, but that is another set of
"unfinished" patches on my ToDo list.
Actually, what I found what I needed was that I wanted a pointer to the
ram_block on that functions. Migration and vga were simple to fix, but
TCG got me completely lost :-(, and at that point I moved to someting else.
Will try to think what were my problems later today.