[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] i8254: Rework & fix interaction with HPET i
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] i8254: Rework & fix interaction with HPET in legacy mode |
Date: |
Sat, 10 Dec 2011 15:54:45 +0000 |
On Sat, Dec 10, 2011 at 15:51, Jan Kiszka <address@hidden> wrote:
> On 2011-12-10 16:49, Blue Swirl wrote:
>>>
>>> +ISADevice *pit_init(int base, qemu_irq irq)
>>
>> Please retain this function in pc.h, or even better, introduce i8254.h.
>
> No concerns about i8254.h, but this function does not qualify for static
> inline.
The function is static inline in a header file not for performance
reasons, but to keep the instantiation separate from device internals.
>>
>>> +{
>>> + ISADevice *dev;
>>> +
>>> + dev = isa_create("isa-pit");
>>> + qdev_prop_set_uint32(&dev->qdev, "iobase", base);
>>> + qdev_init_nofail(&dev->qdev);
>>> + qdev_connect_gpio_out(&dev->qdev, 0, irq);
>>> +
>>> + return dev;
>>> +}
>>> +
>
> Jan
>
- [Qemu-devel] [PATCH 0/2] pit/hpet: Fix legacy mode switching, Jan Kiszka, 2011/12/10
- [Qemu-devel] [PATCH 1/2] hpet: Save/restore cached RTC IRQ level, Jan Kiszka, 2011/12/10
- [Qemu-devel] [PATCH 2/2] i8254: Rework & fix interaction with HPET in legacy mode, Jan Kiszka, 2011/12/10
- Re: [Qemu-devel] [PATCH 2/2] i8254: Rework & fix interaction with HPET in legacy mode, Blue Swirl, 2011/12/10
- Re: [Qemu-devel] [PATCH 2/2] i8254: Rework & fix interaction with HPET in legacy mode, Jan Kiszka, 2011/12/10
- Re: [Qemu-devel] [PATCH 2/2] i8254: Rework & fix interaction with HPET in legacy mode,
Blue Swirl <=
- Re: [Qemu-devel] [PATCH 2/2] i8254: Rework & fix interaction with HPET in legacy mode, Jan Kiszka, 2011/12/10
- Re: [Qemu-devel] [PATCH 2/2] i8254: Rework & fix interaction with HPET in legacy mode, Blue Swirl, 2011/12/10
- Re: [Qemu-devel] [PATCH 2/2] i8254: Rework & fix interaction with HPET in legacy mode, Jan Kiszka, 2011/12/10
- Re: [Qemu-devel] [PATCH 2/2] i8254: Rework & fix interaction with HPET in legacy mode, Blue Swirl, 2011/12/10
Re: [Qemu-devel] [PATCH 0/2] pit/hpet: Fix legacy mode switching, Blue Swirl, 2011/12/10