Re: [Qemu-devel] [PATCH v2 13/18] dev: add an anonymous peripheral container

[Anthony Liguori]

On 12/08/2011 10:27 AM, Kevin Wolf wrote:
> Am 02.12.2011 21:20, schrieb Anthony Liguori:
> > Signed-off-by: Anthony Liguori<address@hidden>
> > ---
> >   hw/qdev.c |   21 ++++++++++++++++++++-
> >   1 files changed, 20 insertions(+), 1 deletions(-)
> >
> > diff --git a/hw/qdev.c b/hw/qdev.c
> > index af4c6a2..5348f26 100644
> > --- a/hw/qdev.c
> > +++ b/hw/qdev.c
> > @@ -240,6 +240,19 @@ static DeviceState *qdev_get_peripheral(void)
> >       return dev;
> >   }
> >
> > +static DeviceState *qdev_get_peripheral_anon(void)
> > +{
> > +    static DeviceState *dev;
> > +
> > +    if (dev == NULL) {
> > +        dev = qdev_create(NULL, "container");
> > +        qdev_property_add_child(qdev_get_root(), "peripheral-anon", dev, NULL);
> > +        qdev_init_nofail(dev);
> > +    }
> > +
> > +    return dev;
> > +}
> > +
> >   DeviceState *qdev_device_add(QemuOpts *opts)
> >   {
> >       const char *driver, *path, *id;
> > @@ -292,7 +305,13 @@ DeviceState *qdev_device_add(QemuOpts *opts)
> >       if (id) {
> >           qdev->id = id;
> >           qdev_property_add_child(qdev_get_peripheral(), qdev->id, qdev, NULL);
> > -    }
> > +    } else {
> > +        static int anon_count;
> > +        gchar *name = g_strdup_printf("device[%d]", anon_count++);
>
> Does any code depend on this name? If not, I would suggest making it a
> bit more convenient for users: g_strdump_printf("%s[%d]", info->name,
> info->anon_count++)

Nothing does and that's a great suggestion, thanks!

Regards,

Anthony Liguori

> Kevin