[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] configure: don't check for Cocoa when detec
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] configure: don't check for Cocoa when detecting SDL. |
Date: |
Wed, 07 Dec 2011 22:26:36 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111105 Thunderbird/8.0 |
Am 07.12.2011 08:47, schrieb Andrzej Zaborowski:
> The SDL check is supposed to set $sdl to "yes" or "no", but with that
> check it leaves $sdl unset on darwin, unless --enable-cocoa was
> specified (which is not needed to enable cocoa anyway).
>
> Signed-off-by: Andrzej Zaborowski <address@hidden>
> ---
> configure | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/configure b/configure
> index 678b982..fb15bc6 100755
> --- a/configure
> +++ b/configure
> @@ -1492,9 +1492,7 @@ EOF
> if test "$_sdlversion" -lt 121 ; then
> sdl_too_old=yes
> else
> - if test "$cocoa" = "no" ; then
> - sdl=yes
> - fi
> + sdl=yes
With no further explanation in the commit description I have doubts if
this is really "safe". Cocoa actually masquerades as SDL in vl.c and has
no display type of its own, so there may well be a real need to suppress
SDL in the --enable-cocoa case. The #ifdef'fery may need to be sanitized
first, at least fully reviewed.
Also please cc me on Cocoa patches.
Thanks,
Andreas
> fi
>
> # static link with sdl ? (note: sdl.pc's --static --libs is broken)
- [Qemu-devel] [PATCH] configure: don't try to compile against known broken curses., Andrzej Zaborowski, 2011/12/07
- [Qemu-devel] [PATCH 1/2] configure: don't check for Cocoa when detecting SDL., Andrzej Zaborowski, 2011/12/07
- Re: [Qemu-devel] [PATCH 1/2] configure: don't check for Cocoa when detecting SDL.,
Andreas Färber <=
- [Qemu-devel] [PATCH 2/2] configure: remove --enable-cocoa (default), add --disable-cocoa., Andrzej Zaborowski, 2011/12/07
- Re: [Qemu-devel] [PATCH 2/2] configure: remove --enable-cocoa (default), add --disable-cocoa., Peter Maydell, 2011/12/07
- Re: [Qemu-devel] [PATCH 2/2] configure: remove --enable-cocoa (default), add --disable-cocoa., Andreas Färber, 2011/12/07
- Re: [Qemu-devel] [PATCH 2/2] configure: remove --enable-cocoa (default), add --disable-cocoa., andrzej zaborowski, 2011/12/08
- Re: [Qemu-devel] [PATCH 2/2] configure: remove --enable-cocoa (default), add --disable-cocoa., andrzej zaborowski, 2011/12/08
Re: [Qemu-devel] [PATCH] configure: don't try to compile against known broken curses., Stefan Weil, 2011/12/07