Re: [Qemu-devel] [PATCH 07/18] qom: add link properties

[Anthony Liguori]

On 12/02/2011 06:15 AM, Kevin Wolf wrote:
> Am 30.11.2011 22:03, schrieb Anthony Liguori:
> > Links represent an ephemeral relationship between devices.  They are meant to
> > replace the qdev concept of busses by allowing more informal relationships
> > between devices.
> >
> > Links are fairly limited in their usefulness without implementing QOM-style
> > subclassing and interfaces.
> >
> > Signed-off-by: Anthony Liguori<address@hidden>
>
> Same thing as in the previous patch: The code doesn't seem to be
> prepared for the case that the "child" (this is not a tree, so there are
> no children...) is removed. While you could say that devices used for
> composition just shouldn't be unpluggable, I don't think you can require
> this for links.

I think we need reference counts to handle this appropriately.

Regards,

Anthony Liguori

> Kevin