[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 14/18] rtc: add a dynamic property for retrievin

From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 14/18] rtc: add a dynamic property for retrieving the date
Date: Fri, 02 Dec 2011 07:20:48 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110831 Lightning/1.0b2 Thunderbird/3.1.13

On 12/02/2011 06:35 AM, Gerd Hoffmann wrote:
The readme has quite a lot of detail about the syntax.  The parser is
pretty complete already.


Ah, nice.  Any plans to support lists there, so it is possible to save
the state of (multiple) in-flight transactions?

I had support for lists locally and just pushed it. It is based on GSList and uses a marker to indicate the type. So:

struct MyDevice {
      int32_t reg1;
      int32_t reg2;

      GSList _type_is(MyRequest) *pending_requests;

This is nice and works and extends to any list type but the syntax is awkward. So I also swizzled things so that we run through the preprocessor first such that we can do:

#define QSList(a) GSList _type_is(MyRequest)

struct MyDevice {
      int32_t reg1;
      int32_t reg2;

      QSList(MyRequest) *pending_requests;


Anthony Liguori

But I want to get us moving on QOM first before I go any further with
this.  We can always go back and remove the manually written visit

Sure, one step at a time.  It helps when reviewing to have a rough idea
of the big pixture though ...


reply via email to

[Prev in Thread] Current Thread [Next in Thread]