[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 02/18] qom: register legacy properties as new st

From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH 02/18] qom: register legacy properties as new style properties
Date: Fri, 02 Dec 2011 13:19:40 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20111104 Red Hat/3.1.16-2.el6_1 Thunderbird/3.1.16


>>> +        prop->info->print(dev, prop, buffer, sizeof(buffer));
>>> +        visit_type_str(v,&ptr, name, errp);
>> I think you can look at prop->info->type here and do something more
>> clever at least for the bool + integer properties.
> That might get a little tough because I want legacy<> types to be
> handled as strings.  I guess we could promote bool/int to non-legacy types.

Indeed.  For chardev and drive properties which will be some kind of
link<..> in the new world (correct?) it probably makes sense to keep
them as legacy<...>.

While being at it:  bus properties might need some more thinking here
too.  Partly they are used for physical addressing, so they will be
replaced by link<...> too I guess?  Some of them have special parsing
and will end up in legacy<...> anyway.  Some are plain integers though
(hda for example) ...


reply via email to

[Prev in Thread] Current Thread [Next in Thread]