[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] hw/smbus_eeprom.c : fix memory leak

From: Zhi Hui Li
Subject: Re: [Qemu-devel] [PATCH] hw/smbus_eeprom.c : fix memory leak
Date: Fri, 02 Dec 2011 13:41:55 +0800
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20110617 Thunderbird/3.1.11

On 2011年12月02日 11:47, Mark Wu wrote:
On 12/02/2011 11:23 AM, Li Zhi Hui wrote:
Signed-off-by: Li Zhi Hui<address@hidden>
hw/smbus_eeprom.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/hw/smbus_eeprom.c b/hw/smbus_eeprom.c
index 5d080ab..d66fbbc 100644
--- a/hw/smbus_eeprom.c
+++ b/hw/smbus_eeprom.c
@@ -142,4 +142,5 @@ void smbus_eeprom_init(i2c_bus *smbus, int nb_eeprom,
qdev_prop_set_ptr(eeprom, "data", eeprom_buf + (i * 256));
+ g_free(eeprom_buf);
The memory pointed by eeprom_buf is used as 'data' buf of 8
SMBusEEPROMDevice after initialization. And it calls qdev_init_nofail,
which will exit on failure. it should be ok to leave it there. Anyway,
you shouldn't free it in the initialization.


I'm afraid I was too fast when I sent a patch with memory leak, and don't look it carefully , It was a pointer to a pointer.

I agree with Mark Wu.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]