[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] main: switch qemu_set_fd_handler to g_io_ad
From: |
Fabien Chouteau |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] main: switch qemu_set_fd_handler to g_io_add_watch |
Date: |
Fri, 25 Nov 2011 15:46:12 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.23) Gecko/20110922 Lightning/1.0b2 Mnenhy/0.8.4 Thunderbird/3.1.15 |
On 25/11/2011 11:46, Paolo Bonzini wrote:
> On 11/25/2011 11:24 AM, Fabien Chouteau wrote:
>>> For POSIX, it would be just a call to
>>> glib_select_fill+select+glib_select_poll. (Everything around
>>> these three would stay in the caller, and the fd_sets would be
>>> passed to os_host_main_loop_wait).
>>
>> Are you sure we have to use select()?
>
> slirp is fd_set---thus select()---based. iohandler too, though it would
> likely be simpler to switch it to poll().
Right, for slirp and iohandler, but it seems wrong to take file
descriptors from g_main_context_query() and put them in the fd_sets for
select(). This part is still in the code today.
--
Fabien Chouteau
- Re: [Qemu-devel] [PATCH 2/2] main: switch qemu_set_fd_handler to g_io_add_watch, Fabien Chouteau, 2011/11/24
- Re: [Qemu-devel] [PATCH 2/2] main: switch qemu_set_fd_handler to g_io_add_watch, Paolo Bonzini, 2011/11/24
- Re: [Qemu-devel] [PATCH 2/2] main: switch qemu_set_fd_handler to g_io_add_watch, Fabien Chouteau, 2011/11/25
- Re: [Qemu-devel] [PATCH 2/2] main: switch qemu_set_fd_handler to g_io_add_watch, Paolo Bonzini, 2011/11/25
- Re: [Qemu-devel] [PATCH 2/2] main: switch qemu_set_fd_handler to g_io_add_watch,
Fabien Chouteau <=
- Re: [Qemu-devel] [PATCH 2/2] main: switch qemu_set_fd_handler to g_io_add_watch, Paolo Bonzini, 2011/11/25
- Re: [Qemu-devel] [PATCH 2/2] main: switch qemu_set_fd_handler to g_io_add_watch, Fabien Chouteau, 2011/11/25
- Re: [Qemu-devel] [PATCH 2/2] main: switch qemu_set_fd_handler to g_io_add_watch, Paolo Bonzini, 2011/11/25
- Re: [Qemu-devel] [PATCH 2/2] main: switch qemu_set_fd_handler to g_io_add_watch, Fabien Chouteau, 2011/11/25
- Re: [Qemu-devel] [PATCH 2/2] main: switch qemu_set_fd_handler to g_io_add_watch, Paolo Bonzini, 2011/11/25
- Re: [Qemu-devel] [PATCH 2/2] main: switch qemu_set_fd_handler to g_io_add_watch, Fabien Chouteau, 2011/11/28