[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1.0] virtio: add and use virtio_set_features
|
From: |
Michael S. Tsirkin |
|
Subject: |
Re: [Qemu-devel] [PATCH 1.0] virtio: add and use virtio_set_features |
|
Date: |
Thu, 24 Nov 2011 19:55:57 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Nov 24, 2011 at 05:49:23PM +0100, Paolo Bonzini wrote:
> On 11/24/2011 05:42 PM, Michael S. Tsirkin wrote:
> >Most users ignore the return value anyway,
> >and virtio_load needs to look at supported features
> >mask for the diagnostic anyway. So let's use virtio_set_features
> >void.
>
> Could some backend make it a hard failure?
I don't see how, there's no way to report a failure from
an io port write.
> If I understand
> correctly, this would have prevented the BAD_FEATURE bug too.
>
> Paolo
Which bug? what would have prevented it.