Re: [Qemu-devel] [v9 Patch 2/6]Qemu: Error classes for file reopen and data sync failure

[supriya kannery]

Luiz Capitulino wrote:
> On Fri, 11 Nov 2011 12:17:35 +0530
> Supriya Kannery <address@hidden> wrote:
>
>   
> > New error classes defined for file reopen failure and data
> > sync error
> >
> > Signed-off-by: Supriya Kannery <address@hidden>
> >
> > ---
> >  qerror.c |    8 ++++++++
> >  qerror.h |    6 ++++++
> >  2 files changed, 14 insertions(+)
> >
> > Index: qemu/qerror.c
> > ===================================================================
> > --- qemu.orig/qerror.c
> > +++ qemu/qerror.c
> > @@ -97,6 +97,14 @@ static const QErrorStringTable qerror_ta
> >          .desc      = "Device '%(device)' is not removable",
> >      },
> >      {
> > +        .error_fmt = QERR_DATA_SYNC_FAILED,
> > +        .desc      = "Syncing of data failed for device '%(device)'",
> > +    },
> > +    {
> > +        .error_fmt = QERR_REOPEN_FILE_FAILED,
> > +        .desc      = "Could not reopen '%(filename)'",
> > +    },
> >     
>
> Is this really needed? I think you could use QERR_OPEN_FILE_FAILED.
>
>   

This could confuse the user, as to what was tried on an
already opened file by qemu. So I feel, QERR_REOPEN_FILE_FAILED can
bring in better clarity to the message passed to the user.

- thanks Supriya