Re: [Qemu-devel] [PATCH 1.0] configure: build position independent executables across the board, by default

[Avi Kivity]

On 11/14/2011 05:00 PM, Peter Maydell wrote:
> On 14 November 2011 14:59, Peter Maydell <address@hidden> wrote:
> > On 14 November 2011 14:41, Avi Kivity <address@hidden> wrote:
> >> +if test "$pie" = "yes" ; then
> >> +  QEMU_CFLAGS="-fPIE -DPIE $QEMU_CFLAGS"
> >> +  LDFLAGS="-Wl,-pie $LDFLAGS"
>
> > It would be good to see some testing that this works on all
> > our random oddball hosts (MacOSX, for instance, which doesn't
> > use GNU ld) and architectures we apply this...
>
> *before we apply this...

We're unlikely to see testing before we apply the patch, and for oddball
archs, even afterwards.  What we can do the qualify it on a build test
(and assume that if it builds, it runs, which I think is a safe assumption).

-- 
error compiling committee.c: too many arguments to function