Re: [Qemu-devel] clk_setup decl missing in virtex_init

[Fabien Chouteau]

On 08/11/2011 00:05, Edgar E. Iglesias wrote:
> On Mon, Nov 07, 2011 at 02:46:47PM -0800, Michael Eager wrote:
>> The declaration of clk_setup is missing in
>> qemu/hw/virtex_ml507.c:
>>
>> static void virtex_init(ram_addr_t ram_size,
>>                         const char *boot_device,
>>                         const char *kernel_filename,
>>                         const char *kernel_cmdline,
>>                         const char *initrd_filename, const char *cpu_model)
>> {
>> ...
>> <no decl for clk_setup>
>> ...
>>     memset(clk_setup, 0, sizeof(clk_setup));
>>
>> This SEGVs because clk_setup is an inline function defined in ppc.h.
>> (I presume that the linker generates an out-of-line copy.)
>>
>> It isn't clear what the declaration should be.  In ppc405_uc.c, there
>> is a decl:
>>    clk_setup_t clk_setup[PPC405EP_CLK_NB];
> 
> 
> Hi
> 
> the following patch seems to work on my side. Fabien, could
> you please see if this was your intention? It seems to be
> commit ddd1055b07fdfe488a22c2275adaca75f4206d30 that
> introduced the segfault.
> 

That's right the memset should have been removed in my patch.

Thanks,

-- 
Fabien Chouteau