[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/6 v2] Makefile.target: Remove libqemu target
From: |
陳韋任 |
Subject: |
Re: [Qemu-devel] [PATCH 4/6 v2] Makefile.target: Remove libqemu target |
Date: |
Fri, 11 Nov 2011 23:15:41 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
> This commit isn't doing what the commit message claims it does.
>
> What you're actually removing is a set of manually inserted
> dependencies of some object files on their source files and
> on cpu.h. There is already no libqemu target in this makefile.
> What you maybe wanted to remove is just the now out of date
> comment line?
I thought the lines below "# libqemu" is related to libqemu.a
, but it's apparently not.
> Now, I think those manually inserted dependencies shouldn't
> be there, because the autogenerated .d files already cover
> the dependencies they specify as far as I can tell.
You mean those *.d file under the build directory?
> But that would be a different commit entirely.)
I'll exclude those manually inserted dependencies from this
series next time.
Regards,
chenwj
--
Wei-Ren Chen (陳韋任)
Computer Systems Lab, Institute of Information Science,
Academia Sinica, Taiwan (R.O.C.)
Tel:886-2-2788-3799 #1667
Homepage: http://people.cs.nctu.edu.tw/~chenwj/
- [Qemu-devel] [PATCH 0/6 v2] Remove libqemu related stuff from QEMU source tree, 陳韋任, 2011/11/11
- [Qemu-devel] [PATCH 4/6 v2] Makefile.target: Remove libqemu target, 陳韋任, 2011/11/11
- [Qemu-devel] [PATCH 1/6 v2] tests/qruncom.c: Remove libqemu.a example, 陳韋任, 2011/11/11
- [Qemu-devel] [PATCH 5/6 v2] Makefile.objs: Remove libqemu_common.a from the comment, 陳韋任, 2011/11/11
- [Qemu-devel] [PATCH 6/6 v2] LICENSE: There is no libqemu.a anymore, 陳韋任, 2011/11/11
- [Qemu-devel] [PATCH 2/6 v2] tests/Makefile: Remove qruncom target, 陳韋任, 2011/11/11
- [Qemu-devel] [PATCH 3/6 v2] qemu-tech.texi: Remove libqemu related stuff from the document, 陳韋任, 2011/11/11