Re: [Qemu-devel] [PATCH 0/3] Standardize on TCGReg for entry points

[Stefan Weil]

Am 09.11.2011 19:03, schrieb Richard Henderson:
> This is the direction in which I believe we should fix the s390
> compilation failure. I've cross-compiled --target-list=i386-softmmu
> for every tcg host to make sure that they all build.
>
> The second patch cannot be split into per-host patches, lest it
> introduce regressions on the way to fixing them.
>
>
> r~
>
>
> Richard Henderson (3):
> tcg: Standardize on TCGReg as the enum for hard registers
> tcg: Use TCGReg for standard tcg-target entry points.
> tcg-sparc: Fix set-but-not used warnings.
>
> tcg/arm/tcg-target.c | 13 +++++++------
> tcg/arm/tcg-target.h | 4 ++--
> tcg/hppa/tcg-target.c | 12 ++++++------
> tcg/hppa/tcg-target.h | 4 ++--
> tcg/i386/tcg-target.c | 13 +++++++------
> tcg/i386/tcg-target.h | 4 ++--
> tcg/ia64/tcg-target.c | 12 ++++++------
> tcg/ia64/tcg-target.h | 4 ++--
> tcg/mips/tcg-target.c | 13 +++++++------
> tcg/mips/tcg-target.h | 4 ++--
> tcg/ppc/tcg-target.c | 8 ++++----
> tcg/ppc/tcg-target.h | 4 ++--
> tcg/ppc64/tcg-target.c | 8 ++++----
> tcg/ppc64/tcg-target.h | 4 ++--
> tcg/sparc/tcg-target.c | 17 +++++++----------
> tcg/sparc/tcg-target.h | 4 ++--
> tcg/tcg.c | 8 ++++----
> tcg/tci/tcg-target.c | 8 ++++----
> tcg/tci/tcg-target.h | 2 +-
> tci.c | 38 +++++++++++++++++++-------------------
> 20 files changed, 92 insertions(+), 92 deletions(-)

Hi Richard,

cross compiling for all tcg targets must have been a really
hard job, so thank you very much for what you have done!

Did you get all needed cross packages from your host's
distribution? Which one?

There remain small risks caused by the modified argument types:

* TCGReg is an enum, so it might be unsigned while int was signed.
  As Blue already wrote, signedness should not matter here, so
  the risk seems to be very low.

* Using TCGReg instead of TCGArg (ia64) should also be a very small risk.

* Using tcg_target_long instead of int32 (mips) potentially allows larger
  arguments. Only the lower 16 bits are used, so this should pose no 
problem.

Therefore for the first two patches, I can add a

Reviewed-by: Stefan Weil <address@hidden>

PS. I still think TCGRegister would be nicer, but having a patch with TCGReg
    is better than nothing. Anthony, patches 1 and 2 are needed for 
QEMU 1.0
    because they fix compilation for ia64 and s390.