Re: [Qemu-devel] [PATCH 1.0 v2] configure: fix detection for xattr.h on modern distributions

[Aneesh Kumar K.V]

On Wed, 09 Nov 2011 17:14:23 +0530, "Aneesh Kumar K.V" <address@hidden> wrote:
> On Wed,  9 Nov 2011 12:33:58 +0200, Avi Kivity <address@hidden> wrote:
> > Modern distributions place xattr.h in /usr/include/sys, and fold
> > libattr.so into libc.  They also don't have an ENOATTR.
> > 
> > Make configure detect this, and add a qemu-xattr.h file that
> > directs the #include to the right place.
> > 
> > Signed-off-by: Avi Kivity <address@hidden>
> > ---
> > 
> > v2: try for libc first, libattr second
> > 
> >  configure                     |   12 ++++++++++--
> >  hw/9pfs/virtio-9p-handle.c    |    2 +-
> >  hw/9pfs/virtio-9p-local.c     |    2 +-
> >  hw/9pfs/virtio-9p-posix-acl.c |    2 +-
> >  hw/9pfs/virtio-9p-xattr.h     |    2 +-
> >  linux-user/syscall.c          |    2 +-
> >  qemu-xattr.h                  |   30 ++++++++++++++++++++++++++++++
> >  7 files changed, 45 insertions(+), 7 deletions(-)
> >  create mode 100644 qemu-xattr.h
> > 
> > diff --git a/configure b/configure
> > index 9e5da44..401d9a6 100755
> > --- a/configure
> > +++ b/configure
> > @@ -129,6 +129,7 @@ xen=""
> >  xen_ctrl_version=""
> >  linux_aio=""
> >  attr=""
> > +libattr=""
> >  xfs=""
> > 
> >  vhost_net="no"
> > @@ -1961,12 +1962,16 @@ if test "$attr" != "no" ; then
> >    cat > $TMPC <<EOF
> >  #include <stdio.h>
> >  #include <sys/types.h>
> > -#include <attr/xattr.h>
> > +#include <sys/xattr.h>
> >  int main(void) { getxattr(NULL, NULL, NULL, 0); setxattr(NULL, NULL, NULL, 
> > 0, 0); return 0; }
> >  EOF
> > -  if compile_prog "" "-lattr" ; then
> > +  if compile_prog "" "" ; then
> > +    attr=yes
> > +  # Older distros have <attr/xattr.h>, and need -lattr:
> > +  elif sed -i s,sys/xattr,attr/xattr, $TMPC && compile_prog "" "-lattr" ; 
> > then
> >      attr=yes
> >      LIBS="-lattr $LIBS"
> > +    libattr=yes
> >    else
> >      if test "$attr" = "yes" ; then
> >        feature_not_found "ATTR"
> > @@ -3032,6 +3037,9 @@ fi
> >  if test "$attr" = "yes" ; then
> >    echo "CONFIG_ATTR=y" >> $config_host_mak
> >  fi
> > +if test "$libattr" = "yes" ; then
> > +  echo "CONFIG_LIBATTR=y" >> $config_host_mak
> > +fi
> 
> Is this needed ? We are adding -lattr to LIBS if needed. What will
> CONFIG_LIBATTR helps us to achieve ?
> 

Ignore that you are using that in qemu-xattr.h

-aneesh