qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] scripts/analyse-9p-simpletrace.py: Add symbolic


From: Harsh Bora
Subject: Re: [Qemu-devel] [PATCH] scripts/analyse-9p-simpletrace.py: Add symbolic names for 9p operations.
Date: Wed, 09 Nov 2011 14:10:47 +0530
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc13 Thunderbird/3.0.5

On 11/09/2011 01:43 PM, Aneesh Kumar K.V wrote:
On Wed,  9 Nov 2011 11:55:51 +0530, Harsh Prateek Bora<address@hidden>  wrote:
Currently, we just print the numerical value of 9p operation identifier in
case of RERROR which is less meaningful for readability. Mapping 9p
operation ids to symbolic names provides a better tracelog:

        RERROR (tag = 1 , id = TWALK , err = 2 )
        RERROR (tag = 1 , id = TUNLINKAT , err = 39 )

It would be nice to map that err to a string. os.strerror(err) may be ?


makes sense, however os.strerror prints multi word text explaining the error and not just the symbolic word, hope its okay:

RERROR (tag = 1 , id = TWALK , err = No such file or directory )
RERROR (tag = 1 , id = TUNLINKAT , err = Directory not empty )

will update in v2.



This patch provides a dictionary of all possible 9p operation symbols mapped
to their numerical identifiers which are likely to be used in future at
various places in this script.

Signed-off-by: Harsh Prateek Bora<address@hidden>
---

-aneesh






reply via email to

[Prev in Thread] Current Thread [Next in Thread]