Re: [Qemu-devel] [PATCH 1.0] configure: fix detection for xattr.h on modern distributions

[Aneesh Kumar K.V]

On Tue,  8 Nov 2011 16:23:50 +0200, Avi Kivity <address@hidden> wrote:
> Modern distributions place xattr.h in /usr/include/sys, and fold
> libattr.so into libc.  They also don't have an ENOATTR.
> 
> Make configure detect this, and add a qemu-xattr.h file that
> directs the #include to the right place.
> 
> Signed-off-by: Avi Kivity <address@hidden>
> ---
>  configure                     |    8 ++++++++
>  hw/9pfs/virtio-9p-handle.c    |    2 +-
>  hw/9pfs/virtio-9p-local.c     |    2 +-
>  hw/9pfs/virtio-9p-posix-acl.c |    2 +-
>  hw/9pfs/virtio-9p-xattr.h     |    2 +-
>  linux-user/syscall.c          |    2 +-
>  qemu-xattr.h                  |   30 ++++++++++++++++++++++++++++++
>  7 files changed, 43 insertions(+), 5 deletions(-)
>  create mode 100644 qemu-xattr.h
> 
> diff --git a/configure b/configure
> index 9e5da44..5158015 100755
> --- a/configure
> +++ b/configure
> @@ -129,6 +129,7 @@ xen=""
>  xen_ctrl_version=""
>  linux_aio=""
>  attr=""
> +attr_in_sys=""
>  xfs=""
> 
>  vhost_net="no"
> @@ -1967,6 +1968,10 @@ EOF
>    if compile_prog "" "-lattr" ; then
>      attr=yes
>      LIBS="-lattr $LIBS"
> +  # On Fedora 15, there is no attr/xattr.h, and no -lattr:
> +  elif sed -i s,attr/,sys/, $TMPC && compile_prog "" "" ; then


But Fedora 15 also provide 

libattr-2.4.44-7.fc15.x86_64
libattr-devel-2.4.44-7.fc15.x86_64

I guess we should first check whether sys/xattr.h is available and then
check for libattr.so. That will avoid linking qemu to libattr if xattr
functions are provided by libc 

-aneesh