Re: [Qemu-devel] [PATCH 4/5] integratorcp: convert integratorcm to VMState

[Peter Maydell]

2011/10/26 Peter Maydell <address@hidden>:
> On 25 October 2011 12:09, Benoît Canet <address@hidden> wrote:
>> +static const VMStateDescription vmstate_integratorcm = {
>> +    .name = "integratorcm",
>> +    .version_id = 1,
>> +    .minimum_version_id = 1,
>> +    .minimum_version_id_old = 1,
>> +    .fields = (VMStateField[]) {
>> +        VMSTATE_UINT32(memsz, integratorcm_state),
>> +        VMSTATE_BOOL(flash_mapped, integratorcm_state),
>
> This raises a question. flash_mapped here is a flag which just
> tracks whether the associated MemoryRegion is currently mapped
> or unmapped. Do we need to do anything special to ensure that
> the MemoryRegion itself is reset to the correct mapped/unmapped
> state on restore?
>
> I recall discussing this kind of thing with Avi on IRC but I
> can't remember what the conclusion was.

Avi, ping? I'm still interested in the answer to this question.

thanks
-- PMM