Re: [Qemu-devel] Do you have a use for a tester of virtio-scsi with CD drives ?

[Andreas Färber]

Hi Thomas,

Am 03.11.2011 23:30, schrieb Thomas Schmitt:
> I tried to activate DPRINTF in hw/scsi-generic.c by removing the "//"
> before
>   #define DEBUG_SCSI
> 
> make yields:
>   .../hw/scsi-generic.c: In function 'scsi_send_command':
>   .../hw/scsi-generic.c:286: error: 'lun' undeclared (first use in this 
> function)
>   .../hw/scsi-generic.c:286: error: 'tag' undeclared (first use in this 
> function)

We're about to release QEMU 1.0(-rc1) and you've just spotted a
compilation issue...

> So i had to change in scsi_send_command():
> 
>   -     DPRINTF("Command: lun=%d tag=0x%x len %zd data=0x%02x", lun, tag,
>   +     DPRINTF("Command: len %zd data=0x%02x",

You've solved this issue 50%! What's missing now is for you to put this
fix into a self-contained patch (without the enabling of DEBUG_SCSI,
etc.) and to submit it using the git-send-email command, so that your
fix can be applied. :)

http://wiki.qemu.org/Contribute/SubmitAPatch

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg