Re: [Qemu-devel] [v8 Patch 3/6]Qemu: Cmd "block_set_hostcache" for dynamic cache change

[Supriya Kannery]

On 11/04/2011 03:30 PM, Kevin Wolf wrote:
> Am 30.10.2011 11:34, schrieb Supriya Kannery:
> > +
> > +    if (bdrv_is_inserted(bs)) {
> > +        /* Reopen file with changed set of flags */
> > +        return bdrv_reopen(bs, bdrv_flags);
> > +    } else {
> > +        /* Save hostcache change for future use */
> > +        bs->open_flags = bdrv_flags;
> > +        return 0;
> > +    }
>
> Maybe the !bdrv_is_inserted() case should be handled in bdrv_reopen(). I
> think it would be the same for changing other flags.

I am yet to look at the conditions specific to other flags. So I can
move this check to bdrv_reopen when implementing one more flag I guess.

> Kevin