[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] qxl: Slot sanity check in qxl_phys2virt() is off by
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH] qxl: Slot sanity check in qxl_phys2virt() is off by one, fix |
Date: |
Fri, 4 Nov 2011 10:34:24 +0100 |
Spotted by Coverity.
Signed-off-by: Markus Armbruster <address@hidden>
---
hw/qxl.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index 84ffd45..c97bebe 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -1006,7 +1006,7 @@ void *qxl_phys2virt(PCIQXLDevice *qxl, QXLPHYSICAL pqxl,
int group_id)
case MEMSLOT_GROUP_HOST:
return (void*)offset;
case MEMSLOT_GROUP_GUEST:
- PANIC_ON(slot > NUM_MEMSLOTS);
+ PANIC_ON(slot >= NUM_MEMSLOTS);
PANIC_ON(!qxl->guest_slots[slot].active);
PANIC_ON(offset < qxl->guest_slots[slot].delta);
offset -= qxl->guest_slots[slot].delta;
--
1.7.6.4
- [Qemu-devel] [PATCH] qxl: Slot sanity check in qxl_phys2virt() is off by one, fix,
Markus Armbruster <=