qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 03/13] qemu-timer: move common code to qemu_r


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v3 03/13] qemu-timer: move common code to qemu_rearm_alarm_timer
Date: Mon, 31 Oct 2011 11:05:44 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110930 Thunderbird/7.0.1

On 10/31/2011 08:23 AM, TeLeMan wrote:
>    static void qemu_rearm_alarm_timer(struct qemu_alarm_timer *t)
>    {
>  -    if (!alarm_has_dynticks(t))
>  +    int64_t nearest_delta_ns;
>  +    assert(alarm_has_dynticks(t));
"mmtimer" and "win32" alarms have no rearm. Should we remove these two alarms?

Yes. I think with iothread they are broken, or almost broken.

Paolo







reply via email to

[Prev in Thread] Current Thread [Next in Thread]