[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] IDE Debug compiler warnings
|
From: |
Max Filippov |
|
Subject: |
Re: [Qemu-devel] [PATCH] IDE Debug compiler warnings |
|
Date: |
Sat, 29 Oct 2011 01:15:51 +0400 |
|
User-agent: |
KMail/1.13.7 (Linux/2.6.40.6-0.fc15.x86_64; KDE/4.6.5; x86_64; ; ) |
> > --- a/hw/ide/ahci.c
> > +++ b/hw/ide/ahci.c
> > @@ -327,7 +327,7 @@ static void ahci_mem_write(void *opaque,
> > target_phys_addr_t addr,
> > }
> > if (addr < AHCI_GENERIC_HOST_CONTROL_REGS_MAX_ADDR) {
> > - DPRINTF(-1, "(addr 0x%08X), val 0x%08X\n", (unsigned) addr, val);
> > + DPRINTF(-1, "(addr 0x%08X), val 0x%08lX\n", (unsigned) addr, val);
>
> val is uint64_t so you need to use PRIx64 (otherwise you
> get warnings on either 32 bit or 64 bit hosts depending
> on whether you use %x or %lx).
This and other ahci format strings fixes are already in the queue:
http://lists.nongnu.org/archive/html/qemu-devel/2011-10/msg03178.html
Thanks.
-- Max