[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 1/6] vvfat: fix out of bounds array_get usage
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH 1/6] vvfat: fix out of bounds array_get usage |
Date: |
Wed, 5 Oct 2011 09:12:03 +0200 |
When reading the address of the first free entry, you cannot
use array_get without first marking all entries as occupied.
This is visible if you change the sectors per cluster on a
floppy from 2 to 1.
Signed-off-by: Paolo Bonzini <address@hidden>
---
block/vvfat.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/block/vvfat.c b/block/vvfat.c
index f567c9a..cee3971 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -799,6 +799,7 @@ static int read_directory(BDRVVVFATState* s, int
mapping_index)
/* root directory */
int cur = s->directory.next;
array_ensure_allocated(&(s->directory), ROOT_ENTRIES - 1);
+ s->directory.next = ROOT_ENTRIES;
memset(array_get(&(s->directory), cur), 0,
(ROOT_ENTRIES - cur) * sizeof(direntry_t));
}
--
1.7.6
- [Qemu-devel] [PATCH 0/6] misc vvfat fixes, Paolo Bonzini, 2011/10/05
- [Qemu-devel] [PATCH 2/6] vvfat: do not fail if the disk has spare sectors, Paolo Bonzini, 2011/10/05
- [Qemu-devel] [PATCH 1/6] vvfat: fix out of bounds array_get usage,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 3/6] vvfat: need to use first_sectors_number to distinguish fdd/hdd, Paolo Bonzini, 2011/10/05
- [Qemu-devel] [PATCH 5/6] vvfat: do not hardcode sector counts in error message, Paolo Bonzini, 2011/10/05
- [Qemu-devel] [PATCH 6/6] vvfat: reorganize computation of disk geometry, Paolo Bonzini, 2011/10/05
- [Qemu-devel] [PATCH 4/6] vvfat: unify and correct computation of sector count, Paolo Bonzini, 2011/10/05
- [Qemu-devel] ping Re: [PATCH 0/6] misc vvfat fixes, Paolo Bonzini, 2011/10/27