qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 05/23] migration: Refactor MigrationState creati


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 05/23] migration: Refactor MigrationState creation
Date: Tue, 04 Oct 2011 09:55:43 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.21) Gecko/20110831 Lightning/1.0b2 Thunderbird/3.1.13

On 10/04/2011 09:44 AM, Juan Quintela wrote:
Anthony Liguori<address@hidden>  wrote:
On 09/23/2011 07:56 AM, Juan Quintela wrote:
Signed-off-by: Juan Quintela<address@hidden>


I think this would fit better if it were migrate_new() or migrate_open().

It definitely should be in the form noun_verb and not noun_verb_noun().

Regards,

You are the native speaker, so I change this one O:-)

It's just consistency, not about what sounds good.

bdrv_new(), bdrv_open(), qemu_chr_open(), memory_region_init(), etc.

Regards,

Anthony Liguori


Later, Juan.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]