[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 01/22] pc: Drop useless test from isa_irq_handler
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] [PATCH 01/22] pc: Drop useless test from isa_irq_handler |
Date: |
Wed, 28 Sep 2011 13:00:47 +0200 |
IsaIrqState::ioapic is always non-NULL. Probably, the concrete
qemu_irq was supposed to be tested, but that's already done by
qemu_set_irq.
Signed-off-by: Jan Kiszka <address@hidden>
---
hw/pc.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/pc.c b/hw/pc.c
index 203627d..a15d165 100644
--- a/hw/pc.c
+++ b/hw/pc.c
@@ -96,9 +96,8 @@ void isa_irq_handler(void *opaque, int n, int level)
if (n < 16) {
qemu_set_irq(isa->i8259[n], level);
}
- if (isa->ioapic)
- qemu_set_irq(isa->ioapic[n], level);
-};
+ qemu_set_irq(isa->ioapic[n], level);
+}
static void ioport80_write(void *opaque, uint32_t addr, uint32_t data)
{
--
1.7.3.4
- [Qemu-devel] [PATCH 20/22] i8259: Fix coding style, (continued)
- [Qemu-devel] [PATCH 20/22] i8259: Fix coding style, Jan Kiszka, 2011/09/28
- [Qemu-devel] [PATCH 10/22] i8259: Reorder intack in pic_read_irq, Jan Kiszka, 2011/09/28
- [Qemu-devel] [PATCH 16/22] i8259: Replace PicState::pics_state with master flag, Jan Kiszka, 2011/09/28
- [Qemu-devel] [PATCH 04/22] pc: Fix and clean up PIC-to-APIC IRQ path, Jan Kiszka, 2011/09/28
- [Qemu-devel] [PATCH 18/22] qdev: Add HEX8 property, Jan Kiszka, 2011/09/28
- [Qemu-devel] [PATCH 07/22] i8259: Move pic_set_irq1 after pic_update_irq, Jan Kiszka, 2011/09/28
- [Qemu-devel] [PATCH 08/22] i8239: Introduce per-PIC output interrupt, Jan Kiszka, 2011/09/28
- [Qemu-devel] [PATCH 19/22] i8259: Convert to qdev, Jan Kiszka, 2011/09/28
- [Qemu-devel] [PATCH 03/22] pc: Convert GSIState::i8259_irq into array, Jan Kiszka, 2011/09/28
- [Qemu-devel] [PATCH 14/22] i8259: Clean up pic_ioport_read, Jan Kiszka, 2011/09/28
- [Qemu-devel] [PATCH 01/22] pc: Drop useless test from isa_irq_handler,
Jan Kiszka <=
- [Qemu-devel] [PATCH 21/22] monitor: Restrict pic/irq_info to supporting targets, Jan Kiszka, 2011/09/28
[Qemu-devel] [PATCH 17/22] i8259: Eliminate PicState2, Jan Kiszka, 2011/09/28
[Qemu-devel] [PATCH 11/22] i8259: Update IRQ state after reset, Jan Kiszka, 2011/09/28