Re: [Qemu-devel] [PATCH] qemu: Fix inject-nmi

[Jan Kiszka]

On 2011-09-25 16:07, Avi Kivity wrote:
> On 09/23/2011 12:31 PM, Lai Jiangshan wrote:
>> >  Moreover: wrong indention.
>> >
>> >  You know that this won't work for qemu-kvm with in-kernel irqchip? You
>> >  may want to provide a patch for that tree, emulating the unavailable
>> >  LINT1 injection via testing the APIC configration and then raising an
>> >  NMI as before if it is accepted.
>> >
>>
>> It works in my box but the NMI is not injected through the in-kernel
>> irqchip,
>> I will implement it as you suggested.
> 
> Somewhat hacky; isn't it better to test LINT1 in the kernel (and
> redefine the KVM_NMI ioctl as "toggle LINT1")?

KVM_NMI is required for user space IRQ chip as well.

Introducing some KVM_SET_LINT1 is an option though. But emulating it for
the NMI button on older kernels sounds worthwhile nevertheless.

Jan

signature.asc
Description: OpenPGP digital signature