[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] ahci: add port I/O index-data pair
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH] ahci: add port I/O index-data pair |
Date: |
Wed, 21 Sep 2011 14:34:41 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2 |
Am 27.08.2011 11:12, schrieb Daniel Verkamp:
> Implement an I/O space index-data register pair as defined by the AHCI
> spec, including the corresponding SATA PCI capability and BAR.
>
> This allows real-mode code to access the AHCI registers; real-mode
> code cannot address the memory-mapped register space because it is
> beyond the first megabyte.
>
> Signed-off-by: Daniel Verkamp <address@hidden>
Thanks, applied to the block branch.
> --- a/hw/ide/ich.c
> +++ b/hw/ide/ich.c
> @@ -72,6 +72,14 @@
> #include <hw/ide/pci.h>
> #include <hw/ide/ahci.h>
>
> +#define ICH9_SATA_CAP_OFFSET 0xA8
> +
> +#define ICH9_IDP_BAR 4
> +#define ICH9_MEM_BAR 5
> +
> +#define ICH9_IDP_INDEX 0x10
> +#define ICH9_IDP_INDEX_LOG2 0x04
Just wondering, why did you choose 0x10 and not 0? The spec reads as if
the implementation could freely choose this, and I can't see what the
first 16 Bytes are used for.
Doesn't make it less correct, of course.
Kevin