qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] MAINTAINERS: update maintainer for target-arm a


From: Paul Brook
Subject: Re: [Qemu-devel] [PATCH] MAINTAINERS: update maintainer for target-arm and ARM devboards
Date: Tue, 20 Sep 2011 22:39:50 +0100
User-agent: KMail/1.13.7 (Linux/3.0.0-1-amd64; KDE/4.6.5; x86_64; ; )

> > Add myself as co-maintainer alongside Paul Brook for the TCG ARM
> > guest implementation (target-arm) and the ARM dev boards (integratorcp,
> > realview, stellaris, versatilepb).
> > 
> > Signed-off-by: Peter Maydell<address@hidden>
> 
> Acked-by: Anthony Liguori <address@hidden>
> 
> Paul, speak now or forever hold your peace ;-)

I approve in general principle, and haven't being paying enough attention to 
make a specific technical judgement.

For the record I consider having multiple maintainers to be a good thing.

IMO the role of a maintainer should be to make sure sub-par code is brought up 
up to standard before it is comitted.  Approving patches is easy, rejecting 
the bad patches[1] is where you add value.  Maintainership is more an 
indication that you're competent to review those bits of code than a grant of 
control.

Paul

[1] With constructive criticism on how to fix the problem.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]