Re: [Qemu-devel] [PATCH 2/2] block: avoid SIGUSR2

[Christoph Hellwig]

On Mon, Sep 19, 2011 at 03:05:47PM +0100, Stefan Hajnoczi wrote:
> On Mon, Sep 19, 2011 at 12:54 PM, Frediano Ziglio <address@hidden> wrote:
> > @@ -547,7 +549,7 @@ static int posix_aio_flush(void *opaque)
> >
> > ?static PosixAioState *posix_aio_state;
> >
> > -static void aio_signal_handler(int signum)
> > +static void posix_aio_notify_event(void)
> > ?{
> > ? ? if (posix_aio_state) {
> 
> Seems like this if statement is always true, hence the condition can
> be removed.  The posix_aio_state global is always non-NULL here.

It is.  In addition to dropping it I'd also recommend moving the
function up so that it's above it's caller.

Btw, what is the point of the qemu_service_io?  Calling qemu_notify_event
directly would seem a lot more obvious, given that the name actually
gives a hint on what it actually does.