Re: [Qemu-devel] [PATCH 0/3] Remove QEMUFile abuse

[malc]

On Sun, 18 Sep 2011, Juan Quintela wrote:

> malc <address@hidden> wrote:
> > On Fri, 16 Sep 2011, Anthony Liguori wrote:
> >
> >> Reviewed-by: Anthony Liguori <address@hidden>
> >> 
> >> malc, please Ack.
> >> 
> >
> > I don't like the commit message.
> 
> Can you be more specific?

QEMUFile predates migration by a few years so could have never been
inteneded to be used for it (leave alone only). There's no such thing
as "vawaudio" (i.e. v vs w).

Commentary aside: fcalls (seek/tell/read/close) can fail and the code 
in the patch doesn't handle it, error path for fwrite does not supply 
information on why the call has failed and furthermore does it via printf, 
also, i believe i mentioned this once before, fwrite (p, 1, n, f) should
really be (p, n, 1, f).

> 
> Can you say what you will preffer?
> 

"Use stdio instead of QEMUFile"

> 
> >> On 09/13/2011 07:52 AM, Juan Quintela wrote:
> >> > Hi
> >> > 
> >> > QEMUFile is intended to be used only for migration.  Change the other
> >> > three users to use FILE * operations directly.  gcc on Fedora 15
> >> > complains about fread/write not checking its return value, so I added
> >> > checks.  But in several places only print an error message (there is
> >> > no error handly that I can hook into).  Notice that this is not worse
> >> > than it is today.
> >> > 
> >> > Later, Juan.
> >> > 
> >> > Juan Quintela (3):
> >> >    vawaudio: port to FILE*
> >> >    wavcapture: port to FILE*
> >> >    ds1225y: port to FILE*
> >> > 
> >> >   audio/wavaudio.c   |   28 +++++++++++++++++++---------
> >> >   audio/wavcapture.c |   38 +++++++++++++++++++++++++-------------
> >> >   hw/ds1225y.c       |   28 ++++++++++++++++------------
> >> >   3 files changed, 60 insertions(+), 34 deletions(-)
> >> > 
> >> 
> 

-- 
mailto:address@hidden