Re: [Qemu-devel] [PATCH v2] Fix X86 CPU topology in KVM mode

[Bharata B Rao]

On Fri, Sep 9, 2011 at 10:44 PM, Anthony Liguori <address@hidden> wrote:
>
> This breaks the build:
>
>  CC    i386-linux-user/helper.o
> /home/anthony/git/qemu/target-i386/helper.c: In function ‘cpu_x86_init’:
> /home/anthony/git/qemu/target-i386/helper.c:1260:47: error: ‘smp_cpus’
> undeclared (first use in this function)
> /home/anthony/git/qemu/target-i386/helper.c:1260:47: note: each undeclared
> identifier is reported only once for each function it appears in
> make[1]: *** [helper.o] Error 1
> make: *** [subdir-i386-linux-user] Error 2
>
> Please do a full build before submitting patches.

Sorry about this, the complexity of qemu and its capability to
support/emulate such wide range of targets is slowly sinking in :)

smp_cpus is defined in vl.c which doesn't even get compiled for
targets like i386-linux-user and hence we end up in above undefined
reference error.

I wouldn't attempt another fix until I spend some time understanding
the code organization for various targets. Meanwhile since the root
cause of the probem and the solution are known, if anyone more well
versed with qemu code organization can fix this, please go ahead.

Regards,
Bharata.