qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Fix include statements for qemu-


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] Fix include statements for qemu-common.h
Date: Fri, 9 Sep 2011 10:00:17 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

On Thu, Sep 08, 2011 at 05:55:32PM +0200, Stefan Weil wrote:
> * qemu-common.h is not a system include file, so it should be included
>   with "" instead of <>. Otherwise incremental builds might fail
>   because only local include files are checked for changes.
> 
> * linux-user/syscall.c included the file twice.
> 
> Cc: Kevin Wolf <address@hidden>
> Cc: Riku Voipio <address@hidden>
> Cc: Jan Kiszka <address@hidden>
> Signed-off-by: Stefan Weil <address@hidden>
> ---
>  hw/virtio-blk.c      |    2 +-
>  linux-user/syscall.c |    3 +--
>  nbd.h                |    2 +-
>  qemu-nbd.c           |    2 +-
>  slirp/libslirp.h     |    2 +-
>  5 files changed, 5 insertions(+), 6 deletions(-)

Thanks, applied to the trivial patches -next tree:
http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches-next

Perhaps I'm being too quick but seems like an obvious fix.

Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]