[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Add CONFIG_QEMU_TIMER to handle qemu-timer-comm
From: |
Lluís |
Subject: |
Re: [Qemu-devel] [PATCH] Add CONFIG_QEMU_TIMER to handle qemu-timer-common.o dep |
Date: |
Tue, 30 Aug 2011 21:40:19 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) |
Lluís writes:
> Michael Roth writes:
>> Hmm, looking again I'm confused why we need to do this in the first
>> place...the
>> rule is:
>> LINK = $(call quiet-command,$(CC) $(QEMU_CFLAGS) $(CFLAGS) $(LDFLAGS) -o
>> $@ $(1) $(LIBS)," LINK $(TARGET_DIR)$@")
>> %$(EXESUF): %.o
>> $(call LINK,$^)
>> According to the documentation $^ should remove duplicate dependencies, so
>> I'm
>> not getting why we need to de-dupe them once they get passed to LINK:
>> http://www.gnu.org/software/make/manual/make.html#index-g_t_0024_005e-948
>> Is there some distinction between duplicate dependencies and duplicate words
>> in
>> the dependency list?
> It does indeed work X'D
> I was blindly searching for words like "duplicate" and "repeat" in
> make's info page.
> I just now realized that in my case, the duplication error appeared only
> with targets defined in line 434 of Makefile.target.
> The fix is as trivial as using this link line:
> $(call LINK,$^)
> Nice catch Michael, we got lost in the discussion :)
BTW, I think tis settles the issue with [1] being "The Right Thing" (TM) :)
The patch in [2] is exactly the same, but outside the tracing patch set.
[1] http://lists.gnu.org/archive/html/qemu-devel/2011-08/msg03150.html
[2] http://lists.gnu.org/archive/html/qemu-devel/2011-08/msg02915.html
Lluis
--
"And it's much the same thing with knowledge, for whenever you learn
something new, the whole world becomes that much richer."
-- The Princess of Pure Reason, as told by Norton Juster in The Phantom
Tollbooth
- Re: [Qemu-devel] [PATCH 1/2] Fix guest agent build with simpletrace, (continued)
- Re: [Qemu-devel] [PATCH 1/2] Fix guest agent build with simpletrace, Blue Swirl, 2011/08/28
- Re: [Qemu-devel] [PATCH 1/2] Fix guest agent build with simpletrace, Lluís, 2011/08/28
- Re: [Qemu-devel] [PATCH 1/2] Fix guest agent build with simpletrace, Blue Swirl, 2011/08/28
- Re: [Qemu-devel] [PATCH 1/2] Fix guest agent build with simpletrace, Stefan Hajnoczi, 2011/08/29
- Re: [Qemu-devel] [PATCH 1/2] Fix guest agent build with simpletrace, Michael Roth, 2011/08/29
- [Qemu-devel] [PATCH] Add CONFIG_QEMU_TIMER to handle qemu-timer-common.o dep, Michael Roth, 2011/08/29
- Re: [Qemu-devel] [PATCH] Add CONFIG_QEMU_TIMER to handle qemu-timer-common.o dep, Stefan Hajnoczi, 2011/08/30
- Re: [Qemu-devel] [PATCH] Add CONFIG_QEMU_TIMER to handle qemu-timer-common.o dep, Lluís, 2011/08/30
- Re: [Qemu-devel] [PATCH] Add CONFIG_QEMU_TIMER to handle qemu-timer-common.o dep, Michael Roth, 2011/08/30
- Re: [Qemu-devel] [PATCH] Add CONFIG_QEMU_TIMER to handle qemu-timer-common.o dep, Lluís, 2011/08/30
- Re: [Qemu-devel] [PATCH] Add CONFIG_QEMU_TIMER to handle qemu-timer-common.o dep,
Lluís <=
- Re: [Qemu-devel] [PATCH] Add CONFIG_QEMU_TIMER to handle qemu-timer-common.o dep, Anthony Liguori, 2011/08/30
- Re: [Qemu-devel] [PATCH] Add CONFIG_QEMU_TIMER to handle qemu-timer-common.o dep, Blue Swirl, 2011/08/30
- Re: [Qemu-devel] [PATCH 1/2] Fix guest agent build with simpletrace, Lluís, 2011/08/29