Re: [Qemu-devel] X86 CPU topology broken in qemu ?

[Bharata B Rao]

On Thu, Aug 25, 2011 at 4:17 PM, Jan Kiszka <address@hidden> wrote:
> On 2011-08-17 07:25, Bharata B Rao wrote:
>> Index: qemu-kvm-0.14.1/target-i386/kvm.c
>> ===================================================================
>> --- qemu-kvm-0.14.1.orig/target-i386/kvm.c
>> +++ qemu-kvm-0.14.1/target-i386/kvm.c
>> @@ -340,6 +340,9 @@ int kvm_arch_init_vcpu(CPUState *env)
>>
>>     cpuid_i = 0;
>>
>> +    if (env->cpuid_features & CPUID_APIC)
>> +        env->cpuid_apic_id = env->cpu_index;
>> +
>
> Moving it only here will break TCG mode. Make sure to test both. I guess
> it's best to move cpuid_apic_id initialization into cpu_x86_init. And
> you need to take care of the external APIC case (i486) as well.

Thanks for the review. The patch was just a quick fix. Let me work on
a proper fix that addresses your comments.

Regards,
Bharata.