[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 7/7] slirp: Fix packing for w32
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH 7/7] slirp: Fix packing for w32 |
Date: |
Mon, 29 Aug 2011 23:15:11 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2011-08-29 20:22, Stefan Weil wrote:
> Am 29.08.2011 12:12, schrieb Jan Kiszka:
>> On 2011-08-28 22:43, Stefan Weil wrote:
>>> Use QEMU_PACKED to eliminate the effects of compiler option
>>> -mms-bitfields.
>>>
>>> Cc: Jan Kiszka<address@hidden>
>>> Signed-off-by: Stefan Weil<address@hidden>
>>> ---
>>> slirp/slirp.h | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/slirp/slirp.h b/slirp/slirp.h
>>> index dcf99d5..28a5c03 100644
>>> --- a/slirp/slirp.h
>>> +++ b/slirp/slirp.h
>>> @@ -199,7 +199,7 @@ struct arphdr {
>>> uint32_t ar_sip; /* sender IP address */
>>> unsigned char ar_tha[ETH_ALEN]; /* target hardware address */
>>> uint32_t ar_tip; /* target IP address */
>>> -} __attribute__((packed));
>>> +} QEMU_PACKED;
>>>
>>> #define ARP_TABLE_SIZE 16
>>>
>>
>> There are further cases in slirp. Please address them as well.
>>
>> Jan
>
> I only addressed those cases which are affected by -mms-bitfields, see
> http://lists.gnu.org/archive/html/qemu-devel/2011-08/msg03428.html.
>
> Other files with __attribute__((packed)) will be handled in separate
> patches.
OK, but this was not clear from the patch description.
>
> I don't think that I missed a case which breaks slirp, but if I did,
> just tell me the struct name so I can fix it, too.
From just looking at the slirp struct, you are likely safe as none
should have odd layouts.
Jan
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 1/7] Add new macro QEMU_PACKED for packed C structures, (continued)
[Qemu-devel] [PATCH 6/7] virtio: Fix packing for w32, Stefan Weil, 2011/08/28
[Qemu-devel] [PATCH 4/7] hpet: Fix packing for w32, Stefan Weil, 2011/08/28
[Qemu-devel] [PATCH 3/7] acpi: Fix packing for w32, Stefan Weil, 2011/08/28
[Qemu-devel] [PATCH 5/7] usb: Fix packing for w32, Stefan Weil, 2011/08/28
[Qemu-devel] [PATCH 7/7] slirp: Fix packing for w32, Stefan Weil, 2011/08/28
Re: [Qemu-devel] [PATCH 0/7] Fix packing for MinGW with -mms-bitfields, Blue Swirl, 2011/08/28
- Re: [Qemu-devel] [PATCH 0/7] Fix packing for MinGW with -mms-bitfields, Stefan Weil, 2011/08/29
- Re: [Qemu-devel] [PATCH 0/7] Fix packing for MinGW with -mms-bitfields, Gerd Hoffmann, 2011/08/29
- Re: [Qemu-devel] [PATCH 0/7] Fix packing for MinGW with -mms-bitfields, TeLeMan, 2011/08/29
- Re: [Qemu-devel] [PATCH 0/7] Fix packing for MinGW with -mms-bitfields, Alexander Graf, 2011/08/29
- Re: [Qemu-devel] [PATCH 0/7] Fix packing for MinGW with -mms-bitfields, Stefan Weil, 2011/08/29
- Re: [Qemu-devel] [PATCH 0/7] Fix packing for MinGW with -mms-bitfields, Kevin Wolf, 2011/08/30
- Re: [Qemu-devel] [PATCH 0/7] Fix packing for MinGW with -mms-bitfields, Stefan Weil, 2011/08/30
- Re: [Qemu-devel] [PATCH 0/7] Fix packing for MinGW with -mms-bitfields, Alexander Graf, 2011/08/30
- Re: [Qemu-devel] [PATCH 0/7] Fix packing for MinGW with -mms-bitfields, Blue Swirl, 2011/08/30