|
| From: | Avi Kivity |
| Subject: | Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields |
| Date: | Thu, 25 Aug 2011 16:17:50 +0300 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:6.0) Gecko/20110816 Thunderbird/6.0 |
On 08/25/2011 04:09 PM, Jan Kiszka wrote:
>> >> We should simply avoid bitfields on externally-defined formats; >> meanwhile we can use __attribute__((gcc_struct)) and keep using those we >> have already. > > +1 We aren't discussing bitfields anymore but essential unaligned (and therefore packed) protocol structs. And I'm not that much worried about going through the few slirp structs but all the other 250 packed ones in entire QEMU.
AFICT gcc_struct is also about alignment, so it should just_work. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.
| [Prev in Thread] | Current Thread | [Next in Thread] |