Re: [Qemu-devel] [PATCH 06/24] QEMUMachine: pass address space to machine init function

[Peter Maydell]

On 24 August 2011 11:11, Avi Kivity <address@hidden> wrote:
> Avoids get_system_memory() everywhere.

> -    machine->init(ram_size, boot_devices,
> +    machine->init(get_system_memory(), get_system_io(), ram_size, 
> boot_devices,
>                   kernel_filename, kernel_cmdline, initrd_filename, 
> cpu_model);

I think this is conceptually wrong. The system memory/IO address spaces
are not configurable properties of the machine model (in the way that
the other arguments to machine->init() are), they're purely an internal
implementation detail of it. (In fact for many of the machines we support
there isn't even any such thing as the system IO space...)

-- PMM