[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] spice-qemu-char.c: Use correct printf format ch
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] spice-qemu-char.c: Use correct printf format char for ssize_t |
Date: |
Thu, 18 Aug 2011 02:06:34 +0100 |
Ping?
-- PMM
On 9 August 2011 23:04, Peter Maydell <address@hidden> wrote:
> Use the correct printf format string character (%z) for ssize_t.
> This fixes a compile failure on 32 bit Linux with spice enabled.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
>
> I note that this seems to have been present since the file
> was introduced, so presumably nobody up til now has attempted
> to compile qemu with spice enabled on a 32 bit box...
>
> This is present in 0.15 (although not fatal since we don't enable
> Werror on release builds); is it worth including compile warning
> fixes in 0.15.1 ?
>
> spice-qemu-char.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/spice-qemu-char.c b/spice-qemu-char.c
> index 95bf6b6..7ec1a9b 100644
> --- a/spice-qemu-char.c
> +++ b/spice-qemu-char.c
> @@ -45,7 +45,7 @@ static int vmc_write(SpiceCharDeviceInstance *sin, const
> uint8_t *buf, int len)
> p += last_out;
> }
>
> - dprintf(scd, 3, "%s: %lu/%zd\n", __func__, out, len + out);
> + dprintf(scd, 3, "%s: %zu/%zd\n", __func__, out, len + out);
> trace_spice_vmc_write(out, len + out);
> return out;
> }
> --
> 1.7.4.1