[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] TCG: Add preprocessor guards for optional tcg o
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH] TCG: Add preprocessor guards for optional tcg ops |
Date: |
Thu, 11 Aug 2011 11:14:55 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:5.0) Gecko/20110707 Thunderbird/5.0 |
On 08/11/2011 09:38 AM, Blue Swirl wrote:
> On Thu, Aug 11, 2011 at 12:58 PM, Avi Kivity <address@hidden> wrote:
>> On 08/11/2011 03:36 PM, Alexander Graf wrote:
>>>
>>>>
>>>> Or to have automatic generation of the optionals based on the
>>>> primitives, if the optionals are not present.
>>>
>>> That's what's happening in the background already, no? The line is towards
>>> tcg users though, not it tcg internal code.
>>>
>>
>> Yes, and it doesn't make sense to optimize through synthetic instructions.
>
> I'd just create all INDEX_op_* enums and adjust TCG targets etc. to
> call tcg_abort() in the default case.
>
Seconded. We can still expand the optional enums exactly as we do now,
but make sure that the enum is always present. That'll clean up a *lot*
of ifdefs throughout tcg/*.
r~
- [Qemu-devel] [PATCH] TCG: Add preprocessor guards for optional tcg ops, Alexander Graf, 2011/08/11
- Re: [Qemu-devel] [PATCH] TCG: Add preprocessor guards for optional tcg ops, malc, 2011/08/11
- Re: [Qemu-devel] [PATCH] TCG: Add preprocessor guards for optional tcg ops, Alexander Graf, 2011/08/11
- Re: [Qemu-devel] [PATCH] TCG: Add preprocessor guards for optional tcg ops, Avi Kivity, 2011/08/11
- Re: [Qemu-devel] [PATCH] TCG: Add preprocessor guards for optional tcg ops, Alexander Graf, 2011/08/11
- Re: [Qemu-devel] [PATCH] TCG: Add preprocessor guards for optional tcg ops, Avi Kivity, 2011/08/11
- Re: [Qemu-devel] [PATCH] TCG: Add preprocessor guards for optional tcg ops, Blue Swirl, 2011/08/11
- Re: [Qemu-devel] [PATCH] TCG: Add preprocessor guards for optional tcg ops,
Richard Henderson <=
- Re: [Qemu-devel] [PATCH] TCG: Add preprocessor guards for optional tcg ops, Alexander Graf, 2011/08/21