|
From: | Avi Kivity |
Subject: | Re: [Qemu-devel] [PATCH 18/24] versatile_pci: convert to memory API |
Date: | Thu, 11 Aug 2011 19:26:20 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:5.0) Gecko/20110707 Thunderbird/5.0 |
On 08/11/2011 07:20 PM, Peter Maydell wrote:
On 8 August 2011 18:07, Avi Kivity<address@hidden> wrote: > -static uint32_t pci_vpb_config_readb (void *opaque, target_phys_addr_t addr) > +static uint64_t pci_vpb_config_read(void *opaque, target_phys_addr_t addr, > + unsigned size) > { > uint32_t val; > - val = pci_data_read(opaque, vpb_pci_config_addr (addr), 1); > - return val; > + val = pci_data_read(opaque, vpb_pci_config_addr(addr), size); > + return size; > } This should be 'return val', not 'return size', I think...
Wow, how did that happen?
(otherwise PCI is broken on versatilepb; tested with your memory-region branch rather than with this particular patch.)
Updated patch to follow, thanks for the report. -- error compiling committee.c: too many arguments to function
[Prev in Thread] | Current Thread | [Next in Thread] |