|
| From: | Luiz Capitulino |
| Subject: | Re: [Qemu-devel] [PATCH v2 40/45] block: Declare qemu_blockalign() in block.h, not block_int.h |
| Date: | Thu, 4 Aug 2011 15:28:38 -0300 |
On Thu, 04 Aug 2011 20:22:15 +0200 Markus Armbruster <address@hidden> wrote: > Luiz Capitulino <address@hidden> writes: > > > On Wed, 3 Aug 2011 15:08:19 +0200 > > Markus Armbruster <address@hidden> wrote: > > > >> Device models should be able to use it without an unclean include of > >> block_int.h. > > > > Nitpick: I'd do the prototype move after patch 38/45 and include the > > block_int.h removal in the patch you're trimming block_int.h includes. > > Care to explain why? Seems more logical to me to solve the dependencies one by one and then drop the includes in one shot. Maybe could even be done in a different series.
| [Prev in Thread] | Current Thread | [Next in Thread] |