[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 02/38] vmsvga: don't remember pci BAR address in
From: |
Avi Kivity |
Subject: |
[Qemu-devel] [PATCH v2 02/38] vmsvga: don't remember pci BAR address in callback any more |
Date: |
Wed, 3 Aug 2011 14:55:32 +0300 |
We're going to remove the callback, so we can't use it to save the
address. Use the pci API instead.
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Avi Kivity <address@hidden>
---
hw/vmware_vga.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c
index 354c221..190b005 100644
--- a/hw/vmware_vga.c
+++ b/hw/vmware_vga.c
@@ -52,8 +52,6 @@ struct vmsvga_state_s {
int on;
} cursor;
- target_phys_addr_t vram_base;
-
int index;
int scratch_size;
uint32_t *scratch;
@@ -761,8 +759,11 @@ static uint32_t vmsvga_value_read(void *opaque, uint32_t
address)
case SVGA_REG_BYTES_PER_LINE:
return ((s->depth + 7) >> 3) * s->new_width;
- case SVGA_REG_FB_START:
- return s->vram_base;
+ case SVGA_REG_FB_START: {
+ struct pci_vmsvga_state_s *pci_vmsvga
+ = container_of(s, struct pci_vmsvga_state_s, chip);
+ return pci_get_bar_addr(&pci_vmsvga->card, 1);
+ }
case SVGA_REG_FB_OFFSET:
return 0x0;
@@ -1247,14 +1248,13 @@ static void pci_vmsvga_map_mem(PCIDevice *pci_dev, int
region_num,
struct vmsvga_state_s *s = &d->chip;
ram_addr_t iomemtype;
- s->vram_base = addr;
#ifdef DIRECT_VRAM
iomemtype = cpu_register_io_memory(vmsvga_vram_read,
vmsvga_vram_write, s, DEVICE_NATIVE_ENDIAN);
#else
iomemtype = s->vga.vram_offset | IO_MEM_RAM;
#endif
- cpu_register_physical_memory(s->vram_base, s->vga.vram_size,
+ cpu_register_physical_memory(addr, s->vga.vram_size,
iomemtype);
s->vga.map_addr = addr;
--
1.7.5.3
- [Qemu-devel] [PATCH v2 00/38] Memory API, batch 2: PCI devices, Avi Kivity, 2011/08/03
- [Qemu-devel] [PATCH v2 01/38] pci: add API to get a BAR's mapped address, Avi Kivity, 2011/08/03
- [Qemu-devel] [PATCH v2 04/38] cirrus: simplify mmio BAR access functions, Avi Kivity, 2011/08/03
- [Qemu-devel] [PATCH v2 20/38] ahci: convert to memory API, Avi Kivity, 2011/08/03
- [Qemu-devel] [PATCH v2 33/38] pci: remove pci_register_bar_simple(), Avi Kivity, 2011/08/03
- [Qemu-devel] [PATCH v2 22/38] lsi53c895a: convert to memory API, Avi Kivity, 2011/08/03
- [Qemu-devel] [PATCH v2 02/38] vmsvga: don't remember pci BAR address in callback any more,
Avi Kivity <=
- [Qemu-devel] [PATCH v2 13/38] ac97: convert to memory API, Avi Kivity, 2011/08/03
- [Qemu-devel] [PATCH v2 29/38] ehci: convert to memory API, Avi Kivity, 2011/08/03
- [Qemu-devel] [PATCH v2 05/38] cirrus: simplify bitblt BAR access functions, Avi Kivity, 2011/08/03
- [Qemu-devel] [PATCH v2 36/38] pci: fold BAR mapping function into its caller, Avi Kivity, 2011/08/03
- [Qemu-devel] [PATCH v2 31/38] xen-platform: convert to memory API, Avi Kivity, 2011/08/03
- [Qemu-devel] [PATCH v2 18/38] ivshmem: convert to memory API, Avi Kivity, 2011/08/03
- [Qemu-devel] [PATCH v2 03/38] vga: convert vga and its derivatives to the memory API, Avi Kivity, 2011/08/03
- [Qemu-devel] [PATCH v2 10/38] pci: pass I/O address space to new PCI bus, Avi Kivity, 2011/08/03
- [Qemu-devel] [PATCH v2 07/38] vga: simplify vga window mmio access functions, Avi Kivity, 2011/08/03
- [Qemu-devel] [PATCH v2 15/38] eepro100: convert to memory API, Avi Kivity, 2011/08/03