Re: [Qemu-devel] [PATCH 03/39] vga: convert vga and its derivatives to the memory API

[Jan Kiszka]

On 2011-07-31 20:46, Avi Kivity wrote:
> On 07/31/2011 09:42 PM, Jan Kiszka wrote:
>> On 2011-07-31 19:57, Avi Kivity wrote:
>> >  Convert all vga memory to the memory API.  Note we need to fall
>> back to
>> >  get_system_memory(), since the various buses don't pass the vga window
>> >  as a memory region.
>> >
>> >  We no longer need to sync the dirty bitmap of the cirrus mapped memory
>> >  banks, since the memory API takes care of that for us.
>> >
>> >  [jan: fix vga-pci logging]
>>
>> grub2 in graphical mode (likely via VBE) is still broken under kvm.
> 
> Sorry, I forgot about it.  Will take a look.
> 
>>   How
>> did you try to address the flush-before-remap issue?
>>
> 
> I haven't.  How does "unconditionally dirty the remapped slot" sound?
> 
> I think it isn't introduced by this patchset, yes?

The patch removes the explicit sync from the cirrus code. But the
underlying issue is older of course.

Jan

signature.asc
Description: OpenPGP digital signature