[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] lm832x: Take DeviceState pointer in lm832x_key_
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] lm832x: Take DeviceState pointer in lm832x_key_event() |
Date: |
Fri, 29 Jul 2011 15:38:29 +0100 |
On 29 July 2011 15:31, Anthony Liguori <address@hidden> wrote:
> On 07/28/2011 09:47 AM, Peter Maydell wrote:
>>
>> Since lm832x has been qdev'ified, its users will generally
>> have a DeviceState pointer rather than an i2c_slave pointer,
>> so adjust lm832x_key_event's prototype to suit.
>>
>> This allows the n810 (its only user) to actually pass a correct
>> pointer to it rather than NULL. The effect is that we no longer
>> segfault when a key is pressed.
>>
>> Signed-off-by: Peter Maydell<address@hidden>
>> ---
>> NB: this patch depends on the OMAP GPIO v2 patchset.
>
> Could you put together a pull request for these devices?
Sure. Do you want just the GPIO patches and this patch,
or shall I put the nand/onenand patches in too?
thanks
-- PMM