[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] lm32: softusb: claim to support full speed
From: |
Michael Walle |
Subject: |
Re: [Qemu-devel] [PATCH] lm32: softusb: claim to support full speed |
Date: |
Wed, 27 Jul 2011 00:01:09 +0200 |
User-agent: |
KMail/1.13.5 (Linux/2.6.32-5-686-bigmem; KDE/4.4.5; i686; ; ) |
Hi Anthony,
could you please apply this patch to the 0.15 (and master) branch.
Am Donnerstag 21 Juli 2011, 20:52:24 schrieb Michael Walle:
> The QEMU keyboard and mouse reports themselves as full speed devices,
> though they are actually low speed devices. Until this is fixed, claim that
> we are supporting full speed devices.
>
> Signed-off-by: Michael Walle <address@hidden>
> ---
> hw/milkymist-softusb.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/hw/milkymist-softusb.c b/hw/milkymist-softusb.c
> index ce2bfc6..abf7b59 100644
> --- a/hw/milkymist-softusb.c
> +++ b/hw/milkymist-softusb.c
> @@ -310,10 +310,12 @@ static int milkymist_softusb_init(SysBusDevice *dev)
> usb_bus_new(&s->usbbus, &softusb_bus_ops, NULL);
>
> /* our two ports */
> + /* FIXME: claim to support full speed devices. qemu mouse and keyboard
> + * report themselves as full speed devices. */
> usb_register_port(&s->usbbus, &s->usbport[0], NULL, 0, &softusb_ops,
> - USB_SPEED_MASK_LOW);
> + USB_SPEED_MASK_LOW | USB_SPEED_MASK_FULL);
> usb_register_port(&s->usbbus, &s->usbport[1], NULL, 1, &softusb_ops,
> - USB_SPEED_MASK_LOW);
> + USB_SPEED_MASK_LOW | USB_SPEED_MASK_FULL);
>
> /* and finally create an usb keyboard */
> s->usbdev = usb_create_simple(&s->usbbus, "usb-kbd");
--
Michael