Re: [Qemu-devel] [PATCH 01/23] Hierarchical memory region API

[Avi Kivity]

On 07/25/2011 09:41 PM, Anthony Liguori wrote:
> > +/* Initialize a memory region
> > + *
> > + * The region typically acts as a container for other memory regions.
> > + */
>
>
> I'm also writing a fair bit of documentation right now.  We should use 
> a common format and declare that the doc format in CODING_STYLE.
>
> I think the two choices are gtk-doc (which I have been using):
<snip>

> I think gtk-doc is more concise and easier to write.  But Doxygen 
> clearly has better tooling.

Updated to use gtk-doc.  Ugh, a large API.

> Otherwise, Reviewed-by: Anthony Liguori <address@hidden> but not 
> tested yet.
>
> I assume that all of the FIXMEs don't actually introduce regressions, 
> right?

Not intentionally.

--
error compiling committee.c: too many arguments to function